1
0
Fork 0

DBG: remove some useless dbghelp calls

This commit is contained in:
Duncan Ogilvie 2018-01-09 23:56:56 +01:00
parent 66017a7442
commit 3ab836225f
No known key found for this signature in database
GPG Key ID: FC89E0AAA0C1AAD8
3 changed files with 28 additions and 33 deletions

View File

@ -82,7 +82,7 @@ SafeSymGetOptions(
STRONG_ACQUIRE();
return SymGetOptions();
}
BOOL
/*BOOL
SafeSymInitializeW(
__in HANDLE hProcess,
__in_opt PCWSTR UserSearchPath,
@ -91,8 +91,8 @@ SafeSymInitializeW(
{
STRONG_ACQUIRE();
return SymInitializeW(hProcess, UserSearchPath, fInvadeProcess);
}
BOOL
}*/
/*BOOL
SafeSymRegisterCallbackW64(
__in HANDLE hProcess,
__in PSYMBOL_REGISTERED_CALLBACK64 CallbackFunction,
@ -101,7 +101,7 @@ SafeSymRegisterCallbackW64(
{
STRONG_ACQUIRE();
return SymRegisterCallbackW64(hProcess, CallbackFunction, UserContext);
}
}*/
DWORD64
SafeSymLoadModuleExW(
__in HANDLE hProcess,
@ -137,7 +137,7 @@ SafeSymGetSearchPathW(
STRONG_ACQUIRE();
return SymGetSearchPathW(hProcess, SearchPath, SearchPathLength);
}
BOOL
/*BOOL
SafeSymEnumSymbols(
__in HANDLE hProcess,
__in ULONG64 BaseOfDll,
@ -148,8 +148,8 @@ SafeSymEnumSymbols(
{
STRONG_ACQUIRE();
return SymEnumSymbols(hProcess, BaseOfDll, Mask, EnumSymbolsCallback, UserContext);
}
BOOL
}*/
/*BOOL
SafeSymGetLineFromAddrW64(
__in HANDLE hProcess,
__in DWORD64 qwAddr,
@ -159,8 +159,8 @@ SafeSymGetLineFromAddrW64(
{
STRONG_ACQUIRE();
return SymGetLineFromAddrW64(hProcess, qwAddr, pdwDisplacement, Line64);
}
BOOL
}*/
/*BOOL
SafeSymFromName(
__in HANDLE hProcess,
__in PCSTR Name,
@ -169,8 +169,8 @@ SafeSymFromName(
{
STRONG_ACQUIRE();
return SymFromName(hProcess, Name, Symbol);
}
BOOL
}*/
/*BOOL
SafeSymFromAddr(
__in HANDLE hProcess,
__in DWORD64 Address,
@ -180,15 +180,15 @@ SafeSymFromAddr(
{
STRONG_ACQUIRE();
return SymFromAddr(hProcess, Address, Displacement, Symbol);
}
BOOL
}*/
/*BOOL
SafeSymCleanup(
__in HANDLE hProcess
)
{
STRONG_ACQUIRE();
return SymCleanup(hProcess);
}
}*/
BOOL
SafeStackWalk64(
__in DWORD MachineType,

View File

@ -34,18 +34,18 @@ SafeSymSetOptions(
DWORD
SafeSymGetOptions(
);
BOOL
/*BOOL
SafeSymInitializeW(
__in HANDLE hProcess,
__in_opt PCWSTR UserSearchPath,
__in BOOL fInvadeProcess
);
BOOL
);*/
/*BOOL
SafeSymRegisterCallbackW64(
__in HANDLE hProcess,
__in PSYMBOL_REGISTERED_CALLBACK64 CallbackFunction,
__in ULONG64 UserContext
);
);*/
DWORD64
SafeSymLoadModuleExW(
__in HANDLE hProcess,
@ -69,38 +69,38 @@ SafeSymGetSearchPathW(
__out_ecount(SearchPathLength) PWSTR SearchPath,
__in DWORD SearchPathLength
);
BOOL
/*BOOL
SafeSymEnumSymbols(
__in HANDLE hProcess,
__in ULONG64 BaseOfDll,
__in_opt PCSTR Mask,
__in PSYM_ENUMERATESYMBOLS_CALLBACK EnumSymbolsCallback,
__in_opt PVOID UserContext
);
BOOL
);*/
/*BOOL
SafeSymGetLineFromAddrW64(
__in HANDLE hProcess,
__in DWORD64 qwAddr,
__out PDWORD pdwDisplacement,
__out PIMAGEHLP_LINEW64 Line64
);
BOOL
);*/
/*BOOL
SafeSymFromName(
__in HANDLE hProcess,
__in PCSTR Name,
__inout PSYMBOL_INFO Symbol
);
BOOL
);*/
/*BOOL
SafeSymFromAddr(
__in HANDLE hProcess,
__in DWORD64 Address,
__out_opt PDWORD64 Displacement,
__inout PSYMBOL_INFO Symbol
);
BOOL
);*/
/*BOOL
SafeSymCleanup(
__in HANDLE hProcess
);
);*/
BOOL
SafeStackWalk64(
__in DWORD MachineType,

View File

@ -1443,10 +1443,6 @@ static void cbExitProcess(EXIT_PROCESS_DEBUG_INFO* ExitProcess)
callbackInfo.ExitProcess = ExitProcess;
plugincbcall(CB_EXITPROCESS, &callbackInfo);
_dbg_animatestop(); // Stop animating
//unload main module
SafeSymUnloadModule64(fdProcessInfo->hProcess, pCreateProcessBase);
//cleanup dbghelp
SafeSymCleanup(fdProcessInfo->hProcess);
//history
dbgcleartracestate();
dbgClearRtuBreakpoints();
@ -1757,7 +1753,6 @@ static void cbUnloadDll(UNLOAD_DLL_DEBUG_INFO* UnloadDll)
if(ModNameFromAddr((duint)base, modname, true))
BpEnumAll(cbRemoveModuleBreakpoints, modname, duint(base));
DebugUpdateBreakpointsViewAsync();
SafeSymUnloadModule64(fdProcessInfo->hProcess, (DWORD64)base);
dprintf(QT_TRANSLATE_NOOP("DBG", "DLL Unloaded: %p %s\n"), base, modname);
if(dbghandledllbreakpoint(modname, false))