GUI: resolved issue #166 (Move Detach command from Debug to File menu + consistent attach/detach icons)

x64_dbg_gui/Project/Src/Gui/MainWindow.cpp

@@ -234,6 +234,7 @@ void MainWindow::refreshShortcuts()
 {
     ui->actionOpen->setShortcut(ConfigShortcut("FileOpen"));
     ui->actionAttach->setShortcut(ConfigShortcut("FileAttach"));
+    ui->actionDetach->setShortcut(ConfigShortcut("FileDetach"));
     ui->actionExit->setShortcut(ConfigShortcut("FileExit"));
 
     ui->actionCpu->setShortcut(ConfigShortcut("ViewCpu"));
@@ -256,7 +257,6 @@ void MainWindow::refreshShortcuts()
     ui->actionRunSelection->setShortcut(ConfigShortcut("DebugRunSelection"));
     ui->actionPause->setShortcut(ConfigShortcut("DebugPause"));
     ui->actionRestart->setShortcut(ConfigShortcut("DebugRestart"));
-    ui->actionDetach->setShortcut(ConfigShortcut("DebugDetach"));
     ui->actionClose->setShortcut(ConfigShortcut("DebugClose"));
     ui->actionStepInto->setShortcut(ConfigShortcut("DebugStepInto"));
     ui->actioneStepInto->setShortcut(ConfigShortcut("DebugeStepInfo"));

x64_dbg_gui/Project/Src/Gui/MainWindow.ui

@@ -39,6 +39,7 @@
     <addaction name="actionOpen"/>
     <addaction name="menuRecent_Files"/>
     <addaction name="actionAttach"/>
+    <addaction name="actionDetach"/>
     <addaction name="separator"/>
     <addaction name="actionExit"/>
    </widget>
@@ -71,7 +72,6 @@
     <addaction name="actionPause"/>
     <addaction name="actionRestart"/>
     <addaction name="actionClose"/>
-    <addaction name="actionDetach"/>
     <addaction name="separator"/>
     <addaction name="actionStepInto"/>
     <addaction name="actioneStepInto"/>

x64_dbg_gui/Project/Src/Utils/Configuration.cpp

@@ -170,6 +170,7 @@ Configuration::Configuration() : QObject()
     // hotkeys settings
     defaultShortcuts.insert("FileOpen", Shortcut(tr("File -> Open"), "F3", true));
     defaultShortcuts.insert("FileAttach", Shortcut(tr("File -> Attach"), "Alt+A", true));
+    defaultShortcuts.insert("FileDetach", Shortcut(tr("File -> Detach"), "Ctrl+Alt+F2", true));
     defaultShortcuts.insert("FileExit", Shortcut(tr("File -> Exit"), "Alt+X", true));
 
     defaultShortcuts.insert("ViewCpu", Shortcut(tr("View -> CPU"), "Alt+C", true));
@@ -193,7 +194,6 @@ Configuration::Configuration() : QObject()
     defaultShortcuts.insert("DebugPause", Shortcut(tr("Debug -> Pause"), "F12", true));
     defaultShortcuts.insert("DebugRestart", Shortcut(tr("Debug -> Restart"), "Ctrl+F2", true));
     defaultShortcuts.insert("DebugClose", Shortcut(tr("Debug -> Close"), "Alt+F2", true));
-    defaultShortcuts.insert("DebugDetach", Shortcut(tr("Debug -> Detach"), "Ctrl+Alt+F2", true));
     defaultShortcuts.insert("DebugStepInto", Shortcut(tr("Debug -> Step into"), "F7", true));
     defaultShortcuts.insert("DebugeStepInfo", Shortcut(tr("Debug -> Step into (skip execptions)"), "Shift+F7", true));
     defaultShortcuts.insert("DebugStepOver", Shortcut(tr("Debug -> Step over"), "F8", true));