AbstractTableView : Renamed repaint() to updateViewport() which is less confusing imo (since whenever i saw repaint() i thought it was QAbstractScrollArea repaint() where actually it was a member function)

CPUDisassembly : Removed all the explicit calls to repaint() which are in fact not needed
BreakpointsView : Same as for CPUDisassembly
CPUSideBar : Same as for CPUDisassembly

src/gui/Src/BasicView/AbstractTableView.cpp

@@ -282,7 +282,7 @@ void AbstractTableView::mouseMoveEvent(QMouseEvent* event)
             int wNewSize = getColumnWidth(mColResizeData.index) + delta;
             setColumnWidth(mColResizeData.index, wNewSize);
             mColResizeData.lastPosX = event->x();
-            repaint();
+            updateViewport();
         }
     }
     break;
@@ -353,7 +353,7 @@ void AbstractTableView::mousePressEvent(QMouseEvent* event)
 
             mGuiState = AbstractTableView::HeaderButtonPressed;
 
-            repaint();
+            updateViewport();
         }
     }
 
@@ -397,7 +397,7 @@ void AbstractTableView::mouseReleaseEvent(QMouseEvent* event)
             mColumnList[i].header.isPressed = false;
         }
 
-        repaint();
+        updateViewport();
     }
 }
 
@@ -992,11 +992,11 @@ void AbstractTableView::reloadData()
 {
     mShouldReload = true;
     emit tableOffsetChanged(mTableOffset);
-    update();
+    this->viewport()->update();
 }
 
 
-void AbstractTableView::repaint()
+void AbstractTableView::updateViewport()
 {
     this->viewport()->update();
 }

src/gui/Src/BasicView/AbstractTableView.h

@@ -130,7 +130,7 @@ public slots:
 
     // Update/Reload/Refresh/Repaint
     virtual void reloadData();
-    void repaint();
+    void updateViewport();
 
     // ScrollBar Management
     void vertSliderActionSlot(int action);

src/gui/Src/BasicView/Disassembly.cpp

@@ -494,7 +494,7 @@ void Disassembly::mouseMoveEvent(QMouseEvent* event)
                     else
                         expandSelectionUpTo(wRowIndex);
 
-                    repaint();
+                    updateViewport();
 
                     wAccept = false;
                 }
@@ -574,7 +574,7 @@ void Disassembly::mousePressEvent(QMouseEvent* event)
 
                     mGuiState = Disassembly::MultiRowsSelectionState;
 
-                    repaint();
+                    updateViewport();
 
                     wAccept = true;
                 }
@@ -605,7 +605,7 @@ void Disassembly::mouseReleaseEvent(QMouseEvent* event)
         {
             mGuiState = Disassembly::NoState;
 
-            repaint();
+            updateViewport();
 
             wAccept = false;
         }
@@ -653,7 +653,7 @@ void Disassembly::keyPressEvent(QKeyEvent* event)
             setTableOffset(getInstructionRVA(getSelectionEnd(), -getNbrOfLineToPrint() + 2));
         }
 
-        repaint();
+        updateViewport();
     }
     else if(key == Qt::Key_Return || key == Qt::Key_Enter)
     {
@@ -1342,7 +1342,7 @@ void Disassembly::disassembleAt(dsint parVA, dsint parCIP, bool history, dsint n
 
             if(wIsAligned == true)
             {
-                repaint();
+                updateViewport();
             }
             else
             {

src/gui/Src/BasicView/HexDump.cpp

@@ -145,7 +145,7 @@ void HexDump::mouseMoveEvent(QMouseEvent* event)
 
                         mGuiState = HexDump::MultiRowsSelectionState;
 
-                        repaint();
+                        updateViewport();
                     }
                 }
             }
@@ -215,7 +215,7 @@ void HexDump::mousePressEvent(QMouseEvent* event)
 
                         mGuiState = HexDump::MultiRowsSelectionState;
 
-                        repaint();
+                        updateViewport();
                     }
                 }
 
@@ -238,7 +238,7 @@ void HexDump::mouseReleaseEvent(QMouseEvent* event)
         {
             mGuiState = HexDump::NoState;
 
-            repaint();
+            updateViewport();
 
             wAccept = false;
         }

src/gui/Src/BasicView/StdTable.cpp

@@ -50,7 +50,7 @@ void StdTable::mouseMoveEvent(QMouseEvent* event)
                 else
                     setSingleSelection(wRowIndex);
 
-                repaint();
+                updateViewport();
 
                 wAccept = false;
             }
@@ -82,7 +82,7 @@ void StdTable::mousePressEvent(QMouseEvent* event)
 
                     mGuiState = StdTable::MultiRowsSelectionState;
 
-                    repaint();
+                    updateViewport();
 
                     wAccept = true;
                 }
@@ -111,7 +111,7 @@ void StdTable::mouseReleaseEvent(QMouseEvent* event)
         {
             mGuiState = StdTable::NoState;
 
-            repaint();
+            updateViewport();
 
             wAccept = false;
         }
@@ -145,7 +145,7 @@ void StdTable::keyPressEvent(QKeyEvent* event)
             setTableOffset(getInitialSelection() - getNbrOfLineToPrint() + 2);
         }
 
-        repaint();
+        updateViewport();
     }
     else
     {

src/gui/Src/Gui/BreakpointsView.cpp

@@ -189,10 +189,6 @@ void BreakpointsView::reloadData()
     }
     mMemBPTable->reloadData();
 
-    mMemBPTable->repaint();
-    mSoftBPTable->repaint();
-    mHardBPTable->repaint();
-
     if(wBPList.count)
         BridgeFree(wBPList.bp);
 }

src/gui/Src/Gui/CPUDisassembly.cpp

@@ -449,8 +449,6 @@ void CPUDisassembly::toggleInt3BPActionSlot()
 
     DbgCmdExec(wCmd.toUtf8().constData());
     //emit Disassembly::repainted();
-
-    repaint();
 }
 
 
@@ -470,8 +468,6 @@ void CPUDisassembly::toggleHwBpActionSlot()
     }
 
     DbgCmdExec(wCmd.toUtf8().constData());
-
-    repaint();
 }
 
 
@@ -531,8 +527,6 @@ void CPUDisassembly::setHwBpAt(duint va, int slot)
     }
     if(wBPList.count)
         BridgeFree(wBPList.bp);
-
-    repaint();
 }
 
 void CPUDisassembly::setNewOriginHereActionSlot()
@@ -566,8 +560,6 @@ void CPUDisassembly::setLabelSlot()
         msg.exec();
     }
 
-    repaint();
-
     GuiUpdateAllViews();
 }
 
@@ -598,8 +590,6 @@ void CPUDisassembly::setLabelAddressSlot()
         msg.exec();
     }
 
-    repaint();
-
     GuiUpdateAllViews();
 }
 
@@ -652,8 +642,6 @@ void CPUDisassembly::setBookmarkSlot()
         msg.exec();
     }
 
-    repaint();
-
     GuiUpdateAllViews();
 }
 
@@ -708,7 +696,6 @@ void CPUDisassembly::toggleFunctionSlot()
         DbgCmdExec(cmd.toUtf8().constData());
     }
 
-    repaint();
 }
 
 void CPUDisassembly::assembleSlot()
@@ -964,8 +951,6 @@ void CPUDisassembly::enableHighlightingModeSlot()
     else
         mHighlightingMode = true;
     reloadData();
-
-    repaint();
 }
 
 void CPUDisassembly::binaryEditSlot()

src/gui/Src/Gui/CPUSideBar.cpp

@@ -272,8 +272,6 @@ void CPUSideBar::mouseReleaseEvent(QMouseEvent* e)
         DbgCmdExec(wCmd.toUtf8().constData());
         break;
     }
-
-    mDisas->repaint();
 }
 
 void CPUSideBar::mouseMoveEvent(QMouseEvent *event)