x64dbg
/
zydis
mirror of https://github.com/x64dbg/zydis
1
0
Fork 0
Code Releases Activity

Minor performance improvements to the `ZydisPrintHexU` function

This commit is contained in:
flobernd 2017-09-16 17:37:14 +02:00
parent 2e979ec737
commit 92cfcdac00
1 changed files with 20 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
src/FormatHelper.c
View File

@ -136,7 +136,6 @@ ZydisStatus ZydisPrintHexU32(char** buffer, size_t bufferLen, uint32_t value, ui
return ZYDIS_STATUS_SUCCESS; return ZYDIS_STATUS_SUCCESS;
} }
char temp[ZYDIS_MAXCHARS_HEX_32];
uint8_t n = 0; uint8_t n = 0;
for (int8_t i = ZYDIS_MAXCHARS_HEX_32 - 1; i >= 0; --i) for (int8_t i = ZYDIS_MAXCHARS_HEX_32 - 1; i >= 0; --i)
{ {
@ -150,27 +149,24 @@ ZydisStatus ZydisPrintHexU32(char** buffer, size_t bufferLen, uint32_t value, ui
if (bufferLen <= (uint8_t)(i + 1)) if (bufferLen <= (uint8_t)(i + 1))
{ {
return ZYDIS_STATUS_INSUFFICIENT_BUFFER_SIZE; return ZYDIS_STATUS_INSUFFICIENT_BUFFER_SIZE;
} }
if (paddingLength > i)
{
n = paddingLength - i - 1;
memset(*buffer, '0', n);
}
} }
if (uppercase) if (uppercase)
{ {
temp[n++] = "0123456789ABCDEF"[v]; (*buffer)[n++] = "0123456789ABCDEF"[v];
} else } else
{ {
temp[n++] = "0123456789abcdef"[v]; (*buffer)[n++] = "0123456789abcdef"[v];
} }
} }
(*buffer)[n] = '\0';
uint8_t offset = 0; *buffer += n;
if (paddingLength > n)
{
offset = paddingLength - n;
memset(*buffer, '0', offset);
}
memcpy(&(*buffer)[offset], temp, n);
(*buffer)[offset + n] = '\0';
*buffer += n + offset;
return ZYDIS_STATUS_SUCCESS; return ZYDIS_STATUS_SUCCESS;
} }
@ -244,7 +240,6 @@ ZydisStatus ZydisPrintHexU64(char** buffer, size_t bufferLen, uint64_t value, ui
return ZYDIS_STATUS_SUCCESS; return ZYDIS_STATUS_SUCCESS;
} }
char temp[ZYDIS_MAXCHARS_HEX_64];
uint8_t n = 0; uint8_t n = 0;
uint8_t c = ((value & 0xFFFFFFFF00000000) ? ZYDIS_MAXCHARS_HEX_64 : ZYDIS_MAXCHARS_HEX_32); uint8_t c = ((value & 0xFFFFFFFF00000000) ? ZYDIS_MAXCHARS_HEX_64 : ZYDIS_MAXCHARS_HEX_32);
for (int8_t i = c - 1; i >= 0; --i) for (int8_t i = c - 1; i >= 0; --i)
@ -259,27 +254,24 @@ ZydisStatus ZydisPrintHexU64(char** buffer, size_t bufferLen, uint64_t value, ui
if (bufferLen <= (uint8_t)(i + 1)) if (bufferLen <= (uint8_t)(i + 1))
{ {
return ZYDIS_STATUS_INSUFFICIENT_BUFFER_SIZE; return ZYDIS_STATUS_INSUFFICIENT_BUFFER_SIZE;
} }
if (paddingLength > i)
{
n = paddingLength - i - 1;
memset(*buffer, '0', n);
}
} }
if (uppercase) if (uppercase)
{ {
temp[n++] = "0123456789ABCDEF"[v]; (*buffer)[n++] = "0123456789ABCDEF"[v];
} else } else
{ {
temp[n++] = "0123456789abcdef"[v]; (*buffer)[n++] = "0123456789abcdef"[v];
} }
} }
(*buffer)[n] = '\0';
uint8_t offset = 0; *buffer += n;
if (paddingLength > n)
{
offset = paddingLength - n;
memset(*buffer, '0', offset);
}
memcpy(&(*buffer)[offset], temp, n);
(*buffer)[offset + n] = '\0';
*buffer += n + offset;
return ZYDIS_STATUS_SUCCESS; return ZYDIS_STATUS_SUCCESS;
} }