From 2665db453b2b59df28838958183eeb31e8cb9b7c Mon Sep 17 00:00:00 2001 From: Duncan Ogilvie Date: Wed, 27 Jul 2022 16:59:57 +0200 Subject: [PATCH] Fix an oversight in the new 'Record trace' checkbox in the trace dialog --- README.md | 1 + src/dbg/plugin_loader.cpp | 2 +- src/gui/Src/Gui/SimpleTraceDialog.cpp | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 742692e2..81e032d3 100644 --- a/README.md +++ b/README.md @@ -78,5 +78,6 @@ You can find an exhaustive list of GitHub contributors [here](https://github.com - [kobalicek](https://github.com/kobalicek) - [athre0z](https://github.com/athre0z) - [ZehMatt](https://github.com/ZehMatt) +- [mrfearless](https://twitter.com/fearless0) Without the help of many people and other open-source projects, it would not have been possible to make x64dbg what is it today, thank you! diff --git a/src/dbg/plugin_loader.cpp b/src/dbg/plugin_loader.cpp index 2ae35b30..2c551eed 100644 --- a/src/dbg/plugin_loader.cpp +++ b/src/dbg/plugin_loader.cpp @@ -1049,7 +1049,7 @@ bool pluginexprfuncregisterex(int pluginHandle, const char* name, const ValueTyp std::vector argTypesVec(argCount); - for(auto i = 0; i < argCount; i++) + for(size_t i = 0; i < argCount; i++) argTypesVec[i] = argTypes[i]; if(!ExpressionFunctions::Register(name, returnType, argTypesVec, cbFunction, userdata)) diff --git a/src/gui/Src/Gui/SimpleTraceDialog.cpp b/src/gui/Src/Gui/SimpleTraceDialog.cpp index dadbf7ad..14434e61 100644 --- a/src/gui/Src/Gui/SimpleTraceDialog.cpp +++ b/src/gui/Src/Gui/SimpleTraceDialog.cpp @@ -53,7 +53,7 @@ void SimpleTraceDialog::on_btnOk_clicked() if(msgyn.exec() == QMessageBox::No) return; } - if(ui->chkRecordTrace->isChecked()) + if(ui->chkRecordTrace->isChecked() && !TraceBrowser::isRecording()) { if(!TraceBrowser::toggleTraceRecording(this)) {