From 8932b34738f4bff301c2b3f8d7f8aadfa96d7413 Mon Sep 17 00:00:00 2001 From: deepzero Date: Wed, 15 Jan 2014 08:49:53 +0100 Subject: [PATCH] fix use of potentially uninitialized handles --- TitanEngine/TitanEngine.cpp | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/TitanEngine/TitanEngine.cpp b/TitanEngine/TitanEngine.cpp index d26a7f3..aa06701 100644 --- a/TitanEngine/TitanEngine.cpp +++ b/TitanEngine/TitanEngine.cpp @@ -19296,13 +19296,13 @@ __declspec(dllexport) bool TITCALL ImporterCopyOriginalIATW(wchar_t* szOriginalF PIMAGE_NT_HEADERS32 PEHeader32; PIMAGE_NT_HEADERS64 PEHeader64; BOOL FileIs64; - HANDLE FileHandle; + HANDLE FileHandle=0; DWORD FileSize; - HANDLE FileMap; + HANDLE FileMap=0; ULONG_PTR FileMapVA; - HANDLE FileHandle1; + HANDLE FileHandle1=0; DWORD FileSize1; - HANDLE FileMap1; + HANDLE FileMap1=0; ULONG_PTR FileMapVA1; ULONG_PTR IATPointer; ULONG_PTR IATWritePointer; @@ -19368,16 +19368,11 @@ __declspec(dllexport) bool TITCALL ImporterCopyOriginalIATW(wchar_t* szOriginalF } } } - else - { - UnMapFileEx(FileHandle, FileSize, FileMap, FileMapVA); - UnMapFileEx(FileHandle1, FileSize1, FileMap1, FileMapVA1); - return(false); - } + UnMapFileEx(FileHandle1, FileSize1, FileMap1, FileMapVA1); } + UnMapFileEx(FileHandle, FileSize, FileMap, FileMapVA); } - UnMapFileEx(FileHandle, FileSize, FileMap, FileMapVA); - UnMapFileEx(FileHandle1, FileSize1, FileMap1, FileMapVA1); + return(false); } __declspec(dllexport) bool TITCALL ImporterLoadImportTable(char* szFileName)