From 0414a061f720879b3a8d40dfe43b9820fbf5a264 Mon Sep 17 00:00:00 2001
From: "Mr. eXoDia" <mr.exodia.tpodt@gmail.com>
Date: Tue, 26 Aug 2014 17:04:47 +0200
Subject: [PATCH] fucking shit, this has been broken since 2010 + fixed
 uninitialized buffer

---
 TitanEngine/Global.Engine.Threading.cpp | 3 +++
 TitanEngine/Global.Garbage.cpp          | 2 +-
 TitanEngine/TitanEngine.cpp             | 1 +
 TitanEngine/TitanEngine.vcxproj         | 4 ++--
 4 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/TitanEngine/Global.Engine.Threading.cpp b/TitanEngine/Global.Engine.Threading.cpp
index 0735970..605d78e 100644
--- a/TitanEngine/Global.Engine.Threading.cpp
+++ b/TitanEngine/Global.Engine.Threading.cpp
@@ -19,7 +19,10 @@ void CriticalSectionDeleteLocks()
     if(!bInitDone)
         return;
     for(int i = 0; i < LockLast; i++)
+    {
+        EnterCriticalSection(&locks[i]);
         DeleteCriticalSection(&locks[i]);
+    }
     bInitDone = false;
 }
 
diff --git a/TitanEngine/Global.Garbage.cpp b/TitanEngine/Global.Garbage.cpp
index 015b67b..597ec79 100644
--- a/TitanEngine/Global.Garbage.cpp
+++ b/TitanEngine/Global.Garbage.cpp
@@ -5,7 +5,7 @@
 #include "Global.Engine.h"
 
 
-wchar_t engineSzEngineGarbageFolder[MAX_PATH];
+wchar_t engineSzEngineGarbageFolder[MAX_PATH] = L"";
 
 // Global.Garbage.functions:
 bool CreateGarbageItem(void* outGargabeItem, int MaxGargabeStringSize)
diff --git a/TitanEngine/TitanEngine.cpp b/TitanEngine/TitanEngine.cpp
index 708404b..3a5f322 100644
--- a/TitanEngine/TitanEngine.cpp
+++ b/TitanEngine/TitanEngine.cpp
@@ -20,6 +20,7 @@ BOOL APIENTRY DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved)
         break;
     case DLL_THREAD_ATTACH:
     case DLL_THREAD_DETACH:
+        break; //this bug has been here since 2010
     case DLL_PROCESS_DETACH:
         if(lpvReserved)
             ExtensionManagerPluginReleaseCallBack();
diff --git a/TitanEngine/TitanEngine.vcxproj b/TitanEngine/TitanEngine.vcxproj
index ea40d4b..ea1ea5f 100644
--- a/TitanEngine/TitanEngine.vcxproj
+++ b/TitanEngine/TitanEngine.vcxproj
@@ -109,7 +109,7 @@
     <Link>
       <AdditionalDependencies>$(ProjectDir)scylla_wrapper_x86.lib;$(ProjectDir)distorm_x86.lib;Imagehlp.lib;psapi.lib;%(AdditionalDependencies)</AdditionalDependencies>
       <ModuleDefinitionFile>$(ProjectDir)TitanEngine.def</ModuleDefinitionFile>
-      <GenerateDebugInformation>false</GenerateDebugInformation>
+      <GenerateDebugInformation>true</GenerateDebugInformation>
       <LinkTimeCodeGeneration>UseLinkTimeCodeGeneration</LinkTimeCodeGeneration>
       <AdditionalOptions>/ignore:4197 %(AdditionalOptions)</AdditionalOptions>
     </Link>
@@ -169,7 +169,7 @@
       <OutputFile>$(OutDir)TitanEngine.dll</OutputFile>
       <IgnoreAllDefaultLibraries>false</IgnoreAllDefaultLibraries>
       <ModuleDefinitionFile>$(ProjectDir)TitanEngine.def</ModuleDefinitionFile>
-      <GenerateDebugInformation>false</GenerateDebugInformation>
+      <GenerateDebugInformation>true</GenerateDebugInformation>
       <SubSystem>Windows</SubSystem>
       <OptimizeReferences>true</OptimizeReferences>
       <EnableCOMDATFolding>true</EnableCOMDATFolding>